Context Navigation

← « Prev
Next Changeset →

Changeset 22034

Timestamp:

09/27/2012 03:39:40 AM (13 years ago)

Author:

nacin

Message:

XML-RPC: Add an if_not_modified_since argument to wp.editPost.

Accepts a GMT date, which is used to compare to the current post_modified_gmt
value for the post being edited. If the post has since been edited (as in, too
old of a date was passed), the edit is rejected as overwriting a newer version.

It is rejected with a HTTP 409 Conflict status code. (Fancy.)

props koke, markoheinjen.
Tests: [UT1049]

see #21397.

File:

: 1 edited

trunk/wp-includes/class-wp-xmlrpc-server.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/wp-includes/class-wp-xmlrpc-server.php

-                      r21959
+                      r22034
             return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+        if ( isset( $content_struct['if_not_modified_since'] ) ) {
+            // If the post has been modified since the date provided, return an error.
+            if ( mysql2date( 'U', $post['post_modified_gmt'] ) > $content_struct['if_not_modified_since']->getTimestamp() ) {
+                return new IXR_Error( 409, __( 'There is a revision of this post that is more recent.' ) );
+            }
+        }
         // convert the date field back to IXR form
         $post['post_date'] = $this->_convert_date( $post['post_date'] );
 …
                 $query['order'] = $filter['order'];
+        }
         if ( isset( $filter['s'] ) ) {
             $query['s'] = $filter['s'];

Note: See TracChangeset for help on using the changeset viewer.

Trac UI Preferences

💎 PREMIUM: Changeset/ - Collection

Make WordPress Core

Context Navigation

Changeset 22034

Legend:

trunk/wp-includes/class-wp-xmlrpc-server.php

Download in other formats: