💦 FULL SET: Changeset/ - Collection

Get WordPress

Make WordPress Core

Changeset 57602


Ignore:
Timestamp:
02/12/2024 09:55:44 PM (23 months ago)
Author:
jorbin
Message:

General: Add an option to configure the site icon in general settings.

This restores the site icon setting to its original home on the settings page where it lives with the title and tagline.

The base for this code was originally added in [32994] and then removed in [33329]. The majority of the modification to that version are to remove the no-js pieces and make the workflow completely inline rather than putting the cropping on a separate page.

Additionally, since image crops rely on the ability to upload an image, this setting is gated by the upload_files capability.

Follow-up to: [32994], [33329].

Props jorbin, audrasjb, mukesh27, joedolson, afercia, kebbet, swissspidy, obenland, jameskoster, kjellr, andraganescu, stacimc, mikeschroder, h71, krupajnanda, huzaifaalmesbah.
Fixes #54370.
See #16434.

Location:
trunk
Files:
1 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Gruntfile.js

    r57492 r57602  
    333333                    [ WORKING_DIR + 'wp-admin/js/tags.js' ]: [ './src/js/_enqueues/admin/tags.js' ],
    334334                    [ WORKING_DIR + 'wp-admin/js/site-health.js' ]: [ './src/js/_enqueues/admin/site-health.js' ],
     335                    [ WORKING_DIR + 'wp-admin/js/site-icon.js' ]: [ './src/js/_enqueues/admin/site-icon.js' ],
    335336                    [ WORKING_DIR + 'wp-admin/js/privacy-tools.js' ]: [ './src/js/_enqueues/admin/privacy-tools.js' ],
    336337                    [ WORKING_DIR + 'wp-admin/js/theme-plugin-editor.js' ]: [ './src/js/_enqueues/wp/theme-plugin-editor.js' ],

  • trunk/src/wp-admin/css/forms.css

    r57572 r57602  
    790790}
    791791
     792.button-add-site-icon{
     793    width: 100%;
     794    cursor: pointer;
     795    text-align: center;
     796    border: 1px dashed #c3c4c7;
     797    box-sizing: border-box;
     798    padding: 9px 0;
     799    line-height: 1.6;
     800    max-width: 270px;
     801}
     802
     803.button-add-site-icon:focus,
     804.button-add-site-icon:hover{
     805    background: white;
     806}
     807
     808.site-icon-section .favicon-preview{
     809    float: left;
     810}
     811.site-icon-section .app-icon-preview{
     812    float: left;
     813    margin: 0 20px;
     814}
     815
     816.site-icon-section .site-icon-preview img{
     817    max-width: 100%;
     818}
     819
     820.button-ad-site-icon:focus{
     821    background-color: #fff;
     822    border-color: #3582c4;
     823    border-style: solid;
     824    box-shadow: 0 0 0 1px #3582c4;
     825    outline: 2px solid transparent;
     826}
     827
    792828/*------------------------------------------------------------------------------
    793829  15.0 - Comments Screen

  • trunk/src/wp-admin/css/site-icon.css

    r46586 r57602  
    88    position: relative;
    99    max-width: 180px;
     10    float: left;
    1011}
    1112
    … …  
    5354    margin-top: 9px;
    5455}
     56
     57.site-icon-section button.reset {
     58    color: #b32d2e;
     59