Opened 16 years ago
Closed 10 years ago
#11598 closed enhancement (wontfix)
code improvements in wp_:dashboard_plugins_output()
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 2.9 |
| Component: | General | Keywords: | needs-patch |
| Focuses: | Cc: |
Attachments (2)
Change History (13)
#3
follow-up:
↓ 6
@
16 years ago
- Keywords tested removed
Does that do {} while(false); loop work? That will only ever run once from looking at the code.
Continue will just skip the rest of the loop and go straight to the conditional.
Best to leave it as a while(true) { break;} , Theres no need for the do syntax which is out of line with the rest of WordPress
#6
in reply to:
↑ 3
@
16 years ago
Replying to dd32:
Does that
do {} while(false);loop work? That will only ever run once from looking at the code.
Yes/Yes: Yes, it does work. Second yes is clear I guess. Let me know if not.
Best to leave it as a
while(true) { break;}, Theres no need for the do syntax which is out of line with the rest of WordPress
Will adopt the patch accordingly to that feedback.
Tested against current trunk, Plugin listing works flawlessly.