🔒 EXCLUSIVE: Ticket/ - High Quality

Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#21442 closed enhancement (fixed)

Themes: change allowed term taxonomy from Width to Layout and add responsive-layout term

Reported by: lancewillett's profile lancewillett Owned by: otto42's profile Otto42
Milestone: 3.8 Priority: low
Severity: normal Version:
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

See #21065 and discussion with WPTRT on ​http://make.wordpress.org/themes/2012/07/18/id-love-your-thoughts-on-adding-two-new/.

"Width" is not accurate since themes can have fluid, fixed, or responsive height as well as width.

"Layout" makes this more abstract.

Attachments (6)

21442.patch​ (3.5 KB) - added by lancewillett 13 years ago.
theme-check.21442.diff​ (2.9 KB) - added by Otto42 12 years ago.
diff for theme-check trunk
21442.diff​ (5.7 KB) - added by lancewillett 12 years ago.
Refresh patch and add Twenty Fourteen
21442.2.patch​ (620 bytes) - added by Otto42 12 years ago.
Core changes only, no theme changes, fixed fluid->flexible issue
21442.3.patch​ (5.7 KB) - added by lancewillett 12 years ago.
Flexible to Fluid after IRC discussion
21442.4.patch​ (5.8 KB) - added by lancewillett 12 years ago.
Refreshed for Twenty Fourteen

Download all attachments as: .zip

Change History (34)

@lancewillett
13 years ago

#1 @sabreuse
13 years ago

+1 on "layout" - and let's get Responsive in there!

#2 @sabreuse
12 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing in favor of ​http://meta.trac.wordpress.org/ticket/78

#3 @nacin
12 years ago

  • Milestone set to Awaiting Review

As found buried at the bottom of 21442.patch​, a change is required in theme.php for this to truly take effect. If WP.org and core gets out of sync there could be problems.

#4 @nacin
12 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#5 follow-up: @sabreuse
12 years ago

Oops! Thanks for the catch on that. For any other requests to add tags to the theme filter, is the best process to have a ticket here for theme.php linked to one on meta for the wp.org interface?

#6 in reply to: ↑ 5 @nacin
12 years ago

Replying to sabreuse:

Oops! Thanks for the catch on that. For any other requests to add tags to the theme filter, is the best process to have a ticket here for theme.php linked to one on meta for the wp.org interface?

I think here (only) is likely sufficient. It realistically needs to be cleared through core before going further. Once it is, we can sync it to WP.org. I think WP.org uses a copy-paste of the core function.

#7 @lancewillett
12 years ago

  • Cc Otto42 added
  • Milestone changed from Awaiting Review to 3.8

Could we get this change into 3.8 please? Otto mentioned updating the WP.org directory taxonomy and this is the most urgent change at the moment with hundreds of new themes that are responsive and don't have a way to show that.

#8 @jcastaneda
12 years ago

  • Cc jomcastaneda@… added