🔥 HOT: Ticket/ - Full Archive

Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#21795 closed defect (bug) (worksforme)

Menu collapse option not saved correctly

Reported by: griffinjt's profile griffinjt Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: Administration Keywords: reporter-feedback close
Focuses: Cc:

Description

The menu collapse option is not saving correctly when at a resolution > 900px. When collapsing and them re-expanding the menu, the menu auto collapses on each new page load. It's caused by the script deleting the folded setting but not actually setting the unfolded setting as far as I can tell.

The attached patch works for me.

Attachments (2)

common-r21757.diff​ (393 bytes) - added by griffinjt 13 years ago.
21795.diff​ (1.4 KB) - added by lessbloat 13 years ago.

Download all attachments as: .zip

Change History (25)

@griffinjt
13 years ago

#1 @SergeyBiryukov
13 years ago

Related: [21574] (for #21349).

According to the ​IRC chat, appears in Chrome 21.0.1180.89 on Mac.

Could not reproduce on Windows yet.

#2 @nacin
13 years ago

  • Milestone changed from Awaiting Review to 3.5

Setting to 3.5 for review.

#3 @bpetty
13 years ago

Yeah, it does seem weird since based on the fix, you should be able to reproduce this bug on Windows/Linux, and probably other browsers as well, but I couldn't reproduce the actual bug on WinXP with same version of Chrome (21.0.1180.89), or Ubuntu and Chrome 18 (so I also can't confirm the patch). Still need another tester on Mac though.

@azaozz might be able to confirm the fix quickly though.

#4 @bpetty
13 years ago

  • Cc bpetty added

#5 @SergeyBiryukov
13 years ago

Could not reproduce in Chrome 21.0.1180.89 on Mac either.

#7 @griffinjt
13 years ago

I also reproduced the same bug in Firefox on Mac - went away before r21573 and reappeared at r21575 (and still exists with trunk). I've tested on both local and live with clean installs.