#23091 closed enhancement (wontfix)
Need to remove deprecated get_bloginfo('url') from _fix_attachment_links() function
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 3.5 |
| Component: | Administration | Keywords: | has-patch |
| Focuses: | Cc: |
Description
get_bloginfo('url'); is deprecated.
Should be home_url();
Attachments (2)
Change History (9)
#4
@
13 years ago
- Component changed from Warnings/Notices to Administration
- Keywords close added
- Type changed from defect (bug) to enhancement
23091.2.diff also renames $site_url to $home_url, to prevent confusion.
However, get_bloginfo( 'url' ) is not deprecated, only home and siteurl parameters are:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/general-template.php#L407
url is still a valid parameter. We use get_bloginfo( 'url' ) in some other places as well.
#5
@
13 years ago
This is confusing in the codex as it states 'home' is deprecated but 'url' is on the same line. Then states consider using home_url() instead. I think the patch is still an improvement as get_bloginfo( 'url' ) returns home_url() anyway. Seems removing a step is good and could be done other places in core as well.
Note: See
TracTickets for help on using
tickets.
edited