⚡ NEW: WordPress/gutenberg/pull/ - High Quality

Skip to content

Conversation

@paulopmt1

What?

I have added the Whatsapp icon to the Social Icons Block, as my first Gutenberg contribuition.

Why?

WhatsApp is really famous in Brazil, it's used for everything here, so I wanted my first Gutenberg contribution to impact these users.

This is related to: #30378

How?

Testing Instructions

  1. Open a Post or Page
  2. Add a Social Block
  3. Add the WhatsApp Icon
  4. Add content to it, normally https://wa.me/your-phone-number
  5. Save and make sure it appears as expected in the editor as well as the preview

Screenshots or screencast

In the editor:

image

Result in the preview:

image

@paulopmt1 paulopmt1 requested a review from ajitbohra as a code owner July 4, 2022 19:55
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 4, 2022
@github-actions

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @paulopmt1! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@talldan talldan added the Needs Design Feedback Needs general design feedback. label Jul 5, 2022
@skorasaurus skorasaurus added the [Block] Social Affects the Social Block - used to display Social Media accounts label Jul 5, 2022
@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jul 13, 2022
@ndiego ndiego self-requested a review July 13, 2022 14:25
@paaljoachim

Hi Paulo Marcos.

Thank you for your very first contribution to Gutenberg! It is much appreciated!

I tested the PR using the Gutenberg PR build. Using this method: https://make.wordpress.org/design/2021/03/03/testing-a-gutenberg-pull-request-pr/
Adding the WhatsApp icon looks identical to adding other social media icons.

Backend:
Screenshot 2022-07-14 at 13 36 02

Testing the Frontend with Twenty Twenty Two showed some weirdness which has I believe nothing to do with this PR, so feel free to skip this part.
Screenshot 2022-07-14 at 13 37 52

Testing the Frontend with Twenty Twenty One showed this:
Screenshot 2022-07-14 at 13 41 18

From what I see this PR in relation to design and functionality works as it should.
Both of the above screenshots shows what it would look like when hovering the cursor over the Whatsapp icon. Showing the status area of the browser with the link.

@paaljoachim paaljoachim removed the Needs Design Feedback Needs general design feedback. label Jul 14, 2022
@paaljoachim paaljoachim requested review from paaljoachim and removed request for paaljoachim July 14, 2022 11:48
@ndiego