You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open a post in the Editor and turn off Network Connectivity via Airplane Mode.
Observe that the offline status indicator displays the text "Working Offline" next to a no-wifi icon, and that text is not cut off as in the "Before" screenshot above.
Testing note: I was not able to consistently reproduce the original issue across various Android devices. I was not able to replicate the issue on a Samsung Galaxy FE20 or Google Pixel 6 Pro, but could consistently replicate it on a Pixel One.
What?
Resolves an Android issue where text was being cut off in the OfflineStatus component when bold text was being used.
Why?
This appears to be a legitimate bug in React Native:
When a bold typeface style is used, the last node of the text appears to be removed.
When there are two or more words in one
<Text>element, the last word is removed:When there is one word in a
<Text>element, the last letter is removed:When there are two or more words in one
<Text>element and a space is added, the space is removed:How?
This PR adds a space to the end of the element in OfflineStatus to workaround the issue. This space does not appear to impact the UI.
Note: the space appears outside of the i18n string to avoid invoking the i18n-no-flanking-whitespace linter error.
This PR also removes an extra
<View style={ containerStyle }></View>that appears to be redundant from its parent.Testing Instructions
Testing note: I was not able to consistently reproduce the original issue across various Android devices. I was not able to replicate the issue on a Samsung Galaxy FE20 or Google Pixel 6 Pro, but could consistently replicate it on a Pixel One.