💦 FULL SET: WordPress/gutenberg/pull/ - Collection

Skip to content
jsnajdr merged 8 commits into from
Dec 18, 2025
Merged

Data: Await resolver implementing isFulfilled #70806

jsnajdr merged 8 commits into from
Dec 18, 2025

Conversation

@johnhooks

What?

Add dispatch of finishResolution when a resolver's isFulfilled callback is true in the @wordpress/data package.

Fixes #70805.

Why?

A deadlock issue was discovered in the @wordpress/data package when using resolveSelect on a selector/resolver pair implementing isFulfilled.

This failed test run from before adding the fix demonstrates the issue.

How?

The concept is to dispatch finishResolution to the metadata store when resolver.isFulfilled is true. This adds the correct state to the store, allowing resolution of the promises in mapResolveSelector and mapSuspendSelector.

@johnhooks johnhooks requested a review from nerrad as a code owner July 20, 2025 17:10
@github-actions

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: johnhooks <[email protected]>
Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.