💥 TRENDING: WordPress/gutenberg/pull/ - High Quality
{{ message }}
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
I think the current behavior is considered a regression introduced in 6.9. Let's backport this PR to 6.9.1. |
t-hamano
added
the
Backport to WP Minor Release
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9.x Editor Tasks
|
Size Change: -12 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
What?
This PR removes the
reisze: falsefrom the color popover and enforces a minimum height on the content, ensuring the popover renders properly in all scenarios.Why?
#73817 added the
resize: false( andflip: true) to the color popover settings to prevent content from being squashed when the popover is triggered near the bottom of the page:Adding the
reisze: falseworks well when the popover content is short, but if the content height exceeds the page height, the overflow content is inaccessible.5c64bc8c83f61868e58bb641d46fe72a.mp4
For color popovers,
resize:trueis not ideal because many palettes may be added by the consumer.How?
resize: false, add a min-height as an inline style. This will allow the popover to flip when triggered at the width of the page.flipistrueby default, so it's not needed.I can't think of any other good approach right now 🤔
Testing Instructions
Screenshots or screencast
58302dfcc9485354d3cd0a0a197cb6d4.mp4