🔒 EXCLUSIVE: WordPress/wordpress develop/pull/ - Collection
{{ message }}
Closed
« Prev #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyBJacobs
force-pushed
the
53386-app-pw-loop
branch
from
316a4e3 to
1c64550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://core.trac.wordpress.org/ticket/53386
Prevent infinite loop on MS if
wp_is_application_passwords_available_for_userincludes a user cap check.Bypass
wp_get_current_user()inis_super_admin()when possible.In #28020
get_userdata()andwp_get_current_user()started returning the same object so there is no need to duplicate the check used in theis_super_admin()function.I need some assistance creating the infinite loop in the tests. I couldn't get one going prior to the patch being applied.