🔒 EXCLUSIVE: WordPress/wordpress develop/pull/ - Uncensored 2025
{{ message }}
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
requested review from
SergeyBiryukov,
boonebgorges and
peterwilsoncc
There was a problem hiding this comment.
Some tests would be lovely to ensure that the change has the desired effect. There will need to be an assertion that expects different results on the runs with memcached.
There should probably be some tests with the other conditions too, I can't see any at a quick glance.
Co-authored-by: Sergey Biryukov <[email protected]>
|
The unit test failures in |
|
@peterwilsoncc Unit tests are fixed. The unit test needed to updated, as there is a change in behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57296
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.