๐Ÿ”’ EXCLUSIVE: WordPress/wp feature notifications/pull/ - High Quality

Skip to content

Conversation

@johnhooks

What?

Implement item and collection schemas for notification the rest-api. Initiate PR early to get feedback, still lots to figure out.

Starts work on #176 to create an update rest endpoint for notifications.

Fixes #194

Why?

The rest-api of notifications should implement item and collection schemas.

How?

It adds schemas that the WP_Rest_Controller can use to validate api requests.

Testing Instructions

Will need to do more research, but I'll be researching core tests and implement something similar.

johnhooks
johnhooks
johnhooks
@johnhooks johnhooks force-pushed the feature/add-update-endpoint branch from 31dd285 to 5ee567b Compare March 26, 2023 12:59
johnhooks
@erikyo erikyo requested a review from Sephsekla March 26, 2023 17:04
@johnhooks johnhooks force-pushed the feature/add-update-endpoint branch 2 times, most recently from bc0178e to bb0d296 Compare March 27, 2023 11:07
@johnhooks

@Sephsekla this is ready to review.

Note: I'm not trying to commit us to anything, but just start work toward an actual rest-api. If anything in this needs to be adjusted as we work to implement notifications, I am 100% on board to either make the changes or support anyone doing the work.

johnhooks
@johnhooks johnhooks added the [Scope] Service The core logic of the WP Notify project. label Mar 27, 2023
Sephsekla