🔒 EXCLUSIVE: Docker/buildx/pull/ - Complete Album!

Skip to content
tonistiigi merged 2 commits into from
Jul 18, 2024
Merged

bake: check printer before printing warnings #2603

tonistiigi merged 2 commits into from
Jul 18, 2024

Conversation

@crazy-max

fixes #2598

A simple fix for a patch release but we should do a proper one as follow-up to avoid this situation with printer in the first place.

@crazy-max crazy-max added this to the v0.16.1 milestone Jul 16, 2024
@crazy-max crazy-max requested a review from tonistiigi July 16, 2024 08:59
@crazy-max crazy-max mentioned this pull request Jul 16, 2024
tonistiigi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is safe. Iiuc the printer = nil and WithOnClose() happen in different goroutines. So even if nil check passes it might be nil once it gets to printWarnings

@crazy-max

I don't think this is safe. Iiuc the printer = nil and WithOnClose() happen in different goroutines. So even if nil check passes it might be nil once it gets to printWarnings

Ah true, I'm taking another look

@crazy-max crazy-max marked this pull request as draft July 17, 2024 07:22
@crazy-max

This comment was marked as outdated.

Sign in to view
@crazy-max crazy-max closed this Jul 17, 2024
@crazy-max crazy-max deleted the bake-fix-progress-panic branch July 17, 2024 12:23
@crazy-max crazy-max removed this from the v0.16.1 milestone Jul 17, 2024
@crazy-max crazy-max restored the bake-fix-progress-panic branch July 18, 2024 15:37
@crazy-max crazy-max reopened this Jul 18, 2024
@crazy-max crazy-max added this to the v0.16.1 milestone Jul 18, 2024