The value sent from Button “Save All Changes”

  • Resolved Alex Lion (ι˜ΏεŠ›η…)

    (@alexclassroom)


    5 years, 9 months ago

    Hi,

    I found the value sent from the button “Save All Changes” was “Save All Changes”, but this value must be inconsistent with localized button string “Save All Changes”.

    This issue will cause the button “Save All Changes” doesn’t work if this button’s string was localized (for any language).

    admin\partials\nginx-helper-general-options.php, line 45.
    Original Code:
    if ( isset( $all_inputs['smart_http_expire_save'] ) && 'Save All Changes' === $all_inputs['smart_http_expire_save'] ) {

    Suggested Code:
    if ( isset( $all_inputs['smart_http_expire_save'] ) && __( 'Save All Changes', 'nginx-helper' ) === $all_inputs['smart_http_expire_save'] ) {

    Or, don’t verify this value sent from this button.

    Regards,

    Alex

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Contributor Chandra Patel

    (@chandrapatel)

    5 years, 8 months ago

    Hi @alexclassroom

    Sorry for the late reply. We have fixed this issue and released the v2.2.2.

    Please update the plugin and let me know if you still facing the issue.

    I’m marking this ticket as resolved.

    Thanks,
    Chandra

    ezflow

    (@ezflow)

    5 years, 8 months ago

    Update fails with this error:
    An error occurred while updating Nginx Helper: The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions. languages, languages/nginx-helper.po, languages/nginx-helper.mo, readme.txt, wercker.yml, composer.json, admin, admin/js, admin/js/nginx-helper-admin.js, admin/predis.php, admin/class-fastcgi-purger.php, admin/class-phpredis-purger.php, admin/class-predis-purger.php, admin/css, admin/css/nginx-helper-admin.css, admin/index.php, admin/partials, admin/partials/nginx-helper-general-options.php, admin/partials/nginx-helper-sidebar-display.php, admin/partials/nginx-helper-support-options.php, admin/partials/nginx-helper-admin-display.php, admin/class-purger.php, admin/icons, admin/icons/font, admin/icons/font/nginx-fontello.ttf, admin/icons/font/nginx-fontello.svg, admin/icons/font/nginx-fontello.eot, admin/icons/font/nginx-fontello.woff, admin/icons/config.json, admin/icons/nginx-icon-32×32.png, admin/icons/css, admin/icons/css/nginx-fontello.css, admin/class-nginx-helper-admin.php, index.php, nginx-helper.php, phpcs.xml, composer.lock, class-nginx-helper-wp-cli-command.php, uninstall.php, includes, includes/class-nginx-helper-deactivator.php, includes/class-nginx-helper.php, includes/class-nginx-helper-loader.php, includes/index.php, includes/class-nginx-helper-activator.php, includes/class-nginx-helper-i18n.php

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘The value sent from Button “Save All Changes”’ is closed to new replies.