jmslbam
Forum Replies Created
-
Hi Anton,
Thank you for you quick reply. If had a release of a other big project so my focus was there the last days, sorry.
The Asset Optimization logic
Thank you for your explaination. It’s indeed not necessary to combine everything to 1 files, especially with HTTP/2.About the styles
Correct, the styles are still there, but now only once, and not repeated for every enqueued CSS file. That is the reason I disable the assets optimization of HB.Kinds regards,
Jaime!
Cookiebot doesn’t rapports the cookie, so that’s ok.
I will remove vimeo from the blocking “regex” so that all other video will be blocked.
# data-cookieconsent=”ignore”
Thank you for the tip, but that won’t be necessary when remove vimeo.com from the regex.#Youtube no-cookie url.
Wouldn’t this be also the case with the Youtube no-cookie https://www.youtube-nocookie.com/embed/sRrqF8eXs38# Default behaviour
And wouldn’t this then be default behaviour for Vimeo and the No-cookie video’s within Cookiebot Autoembed blokkage functionality?Because now video’s are being blocked when it’s not necessary.
Hope it makes sense and you can confirm the above reasoning.
Forum: Plugins
In reply to: [Save and Share Cart for WooCommerce] Email being sent from [email protected]I think this should be fixed on a higher level within your WordPress installation.
For instance, if I dont configure my Gravity Forms properly it will also send an e-mail from [email protected]. So if you properly set it globaly, then it is fixed in you whole WP installation.
With https://wordpress.org/plugins/wp-change-default-from-email/ or via a PHP WordPress filter https://zemez.io/wordpress/support/how-to/how-to-change-sender-name-in-outgoing-wordpress-email/ or even https://wordpress.org/plugins/post-smtp/
Hope it helps
Forum: Plugins
In reply to: [Save and Share Cart for WooCommerce] Not working with bundled productsHi Dave and Ankit,
You can fix it by passing the $item here:
$woocommerce->cart->add_to_cart( $item[‘product_id’], $item[‘quantity’], $item[‘variation_id’], $item[‘variation’], $item );
At least it fixed it for my implementation with the “woo-product-bundle” plugin.
I can’t fork the plugin otherwise I would create a PR for you.
Ciao!
Forum: Plugins
In reply to: [Save and Share Cart for WooCommerce] Remember coupon when saving cartBy the way, I checked out your website and you aren’t using this plugin. You are using https://codecanyon.net/item/save-share-cart-for-woocommerce/5568059, right?
Forum: Plugins
In reply to: [Save and Share Cart for WooCommerce] Remember coupon when saving cartWhat I have done (programmed), is I have added a new product which is called “Korting” 😉 and have it an open price field (via Gravity Forms WooCommercec add-on).
Then while hooking into “woocommerce_before_calculate_totals” action and “woocommerce_get_item_data” I found this Discount product and multiplied the price with “-1”.
If you hide this product from the catalog, then only you as admin can find it and from the Cart overview you can’t click on it the visit the detailpage.
This way you are super flexible and this plugin keeps it focus on it’s core feature, right?
Jaime Martinez
Developer
https://jaimemartinez.nlForum: Plugins
In reply to: [WP Performance Pack] 502 Bad Gateway errorAh you just replied:
OSX: 18.6.0 Darwin Kernel Version
PHP Version 7.3.5Configure Command ‘./configure’ ‘–enable-static=’ ‘–enable-fpm’ ‘–enable-zip’ ‘–enable-soap’ ‘–enable-opcache’ ‘–enable-mbregex’ ‘–enable-mbstring’ ‘–enable-pdo’ ‘–enable-ftp’ ‘–enable-sockets’ ‘–enable-exif’ ‘–enable-bcmath’ ‘–enable-calendar’ ‘–enable-shmop’ ‘–enable-pcntl’ ‘–with-pdo-mysql’ ‘–with-openssl=/usr/local/opt/[email protected]’ ‘–with-curl=/usr/local/opt/curl’ ‘–with-zlib-dir=/usr/local/opt/zlib’ ‘–with-gettext=/usr/local/opt/gettext’ ‘–with-xmlrpc’ ‘–with-mysqli’ ‘–with-pcre-regex’ ‘–with-jpeg-dir’ ‘–with-png-dir’ ‘–with-freetype-dir’ ‘–with-gd’ ‘–with-bz2=/usr/local/opt/bzip2’ ‘–with-xsl’ ‘–with-iconv=/usr/local/opt/libiconv’ ‘–without-pear’ ‘–without-sqlite3’ ‘–without-pdo-sqlite’ ‘–prefix=/Users/runner/runners/2.159.2/work/_temp/local-lightning-php/php-7.3.5/build’
I will disable all my plugins and check if they maybe interfere. (Tomorrow)
Thank you for your time and will report back.
Ciao!
Forum: Plugins
In reply to: [WP Performance Pack] 502 Bad Gateway errorOk, it is in the is_native_gettext_available() check.
I traced it back to there and when I “return 1;” early in the function, no 502.
Then I debugged the function further and found that $native_gettext_test = $mo->translate( ‘native-gettext-test’ );
was the trigger.These were also the notices / errors I found in logs:
`
[28-Feb-2020 09:30:14] WARNING: [pool www] child 6321 said into stderr: “ld: warning: option -s is obsolete and being ignored”
[28-Feb-2020 10:00:01] WARNING: [pool www] child 6320 said into stderr: “sh: /usr/bin/dot: No such file or directory”
[28-Feb-2020 10:06:01] WARNING: [pool www] child 6320 said into stderr: “close failed in file object destructor:”
[28-Feb-2020 10:06:01] WARNING: [pool www] child 6320 said into stderr: “sys.excepthook is missing”
[28-Feb-2020 10:06:01] WARNING: [pool www] child 6320 said into stderr: “lost sys.stderr”
[28-Feb-2020 10:16:18] WARNING: [pool www] child 6321 said into stderr: “dyld: lazy symbol binding failed: Symbol not found: _iconv_open”
[28-Feb-2020 10:16:18] WARNING: [pool www] child 6321 said into stderr: ” Referenced from: /Applications/Local.app/Contents/Resources/extraResources/lightning-services/php-7.3.5+3/bin/darwin/sbin/../shared-dylibs/libintl.8.dylib”
[28-Feb-2020 10:16:18] WARNING: [pool www] child 6321 said into stderr: ” Expected in: /Applications/Local.app/Contents/Resources/extraResources/lightning-services/php-7.3.5+3/bin/darwin/sbin/../shared-dylibs/libiconv.2.dylib”`I don’t get this error on my external webserver so I think it has to do with Local by Flywheel not having loaded al the stuff “WPPP_Native_Gettext” needs… I guess.
I’m researching some more, by checking out a different development enviroment.
Jaime!
Forum: Plugins
In reply to: [WP Performance Pack] 502 Bad Gateway errorHi Bjroen,
Thank you for the update. I have tested it and it still returns a 503.
I checked my phpinfo() and saw that PHP is compiled with gettext support. I’m using https://localbyflywheel.com
I’m researching even deeper to see where the 503 may be comming from. I’ll keep you posted!
Jaime
Forum: Plugins
In reply to: [Save and Share Cart for WooCommerce] Unable to change Share cart button textI can confirm that it works in 1.0.4.
The other label I could change with loco-translate. That’s a better solution to change the text within a plugin. That way you’re not building a complete translation interface for each “label” or “term”. Is less code, less maintanece and it keeps the plugin lightweight, right?
Maybe it’s an option to switch to GitHub, I have noticed that it’s a bit more developer friendly then BitBucket.
By the way, the WooCommerce way to add a notice is via
wc_add_notice( __( 'Cart removed successfully.', 'wcssc' ), 'success' );and a
wc_print_notices();in the template file.Hope I can start contributing to this plugin with some PR’s, kind regards!
- This reply was modified 5 years, 10 months ago by jmslbam.
Unfortunately. If you could do that, that would be great!
Last week I added an extra “remote” remote to my original repo so I wouldn’t have to push to it individualy. I think I used this article to set it up. https://gist.github.com/rvl/c3f156e117e22a25f242
Ciao and thank you for taking the time!
I see a bit more options, but no options to Fork it. Without a Fork I can’t open a PR. I found the settings a “settings > repository detail > forking dropdown”.
You have that option also?
Ah, I see you already doing it at single-saved-cart.php, but not yet on template-saved-carts.php.
Ciao!
