🔞 ADULT: Ticket/ - Complete Album!

Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#55422 closed task (blessed) (fixed)

Add a .git-blame-ignore-revs file

Reported by: helen's profile helen Owned by: helen's profile helen
Milestone: 6.0 Priority: normal
Severity: minor Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

While we still use SVN and Trac as our sources of truth in core development, plenty of contributors use GitHub for their contribution workflows. GitHub is currently rolling out support for a Git-standard .git-blame-ignore-revs file in visual blame and ​it has been turned on for the WordPress org per the Gutenberg team's request. It would be nice to have a file with things like the classic "pinking shears" commits and others that are purely formatting changes. Examples would be [34534] and [42343].

Change History (21)

This ticket was mentioned in ​PR #2433 on ​WordPress/wordpress-develop by ​helen.
4 years ago #1

  • Keywords has-patch added

This adds a .git-blame-ignore-revs file to exclude certain commits from visual blame on GitHub.com, which can also be used on the command line via git blame --ignore-revs-file .git-blame-ignore-revs.

Trac ticket: https://core.trac.wordpress.org/ticket/55422

#2 @helen
4 years ago

My initial PR is not a complete list of commits, though it does include all the commits I found for "pinking shears" with the exception of one that I noticed contained other changes. I would really love some help double checking these commits to make sure we're not including any that are anything besides whitespace/style fixes; it's better to be conservative to start. Would also like feedback / suggestions on the format of the file, particularly around the comments and how we label things to be able to maintain this file now and into the future.

​costdev commented on ​PR #2433:
4 years ago #3

Some "Code is Poetry" commits:
{{{bash
e4e1a54567dca12048e5344ab5b60a85e0d96743 # [4375]
e37aff4320b89bd94e21517f65d298f9f1fe6b37 # [45559]
}}}
and you already have this one under # PHPCS:
{{{bash
8f95800d52c1736d651ae6e259f90ad4a0db2c3f # [42343]
}}}

​helen commented on ​PR #2433:
4 years ago #4

@costdev I personally see those two commits as more than purely stylistic; I don't believe anything would have been affected by those specifically but sometimes subtle things like that (especially that final falsey check) can cause side effects and I would want to see those in the history. Definitely open to the idea that being more liberal about leaving commits out of our default code archaeology is a good idea, but I think I'd need a lot of convincing :)