🔞 ADULT: Ticket/ - Uncensored 2025

Get WordPress

Make WordPress Core

Opened 8 months ago

Last modified 7 weeks ago

#63355 assigned defect (bug)

Image tests skipped in GitHub Actions

Reported by: mattyrob's profile MattyRob Owned by: desrosj's profile desrosj
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: tests Cc:

Description

ClassicPress, a fork of WordPress, uses GitHub actions for automated CI testing in a similar way to WordPress.

The runner images for Ubuntu has recently been updated to 24.04 for latest and we have noticed that the slimmed down OS runner image has introduced issues in many of the image tests in core.

This PR may add some more context:
​https://github.com/ClassicPress/ClassicPress/pull/1749

We have as yet not managed to find a solution beyond maintaining the OS runner at Ubuntu 22.04.

We have noted however the a large number of the image tests in WordPress are being skipped in automated testing for what seems to be the same reason. It seems that around 37 tests related to Imagick are being skipped and some GD tests are being skipped for heic and avif image types.

The only solution that works currently seems to be fixing the runner to Ubuntu 22.04

Attachments (1)

Screenshot 2025-04-26 at 12.37.03.png​ (353.8 KB) - added by MattyRob 8 months ago.
Screen grab of failing tests on GitHub

Download all attachments as: .zip

Change History (5)

@MattyRob
8 months ago

Screen grab of failing tests on GitHub

This ticket was mentioned in ​PR #9919 on ​WordPress/wordpress-develop by ​@desrosj.
3 months ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/63355

#2 @desrosj
3 months ago

  • Keywords has-patch has-unit-tests removed
  • Milestone changed from Awaiting Review to 6.9
  • Owner set to desrosj
  • Status changed from new to assigned

#3 @desrosj
3 months ago

  • Keywords has-patch added
  • Version trunk deleted

Thanks @MattyRob!

It looks like these are the only remaining skipped tests related to AVIF/HEIC today.

6) Test_Image_Resize_GD::test_resize_heic
No HEIC support in the editor engine on this system.

GD does not yet have support for the HEIC format, so this one can't be fixed at this time. ​Support for reading the Exif data from an HEIF file seems to be slated for PHP 8.5, but the ​pull request that adds support for manipulating these files is still in draft.

14) WP_Test_REST_Attachments_Controller::test_upload_unsupported_image_type
The image editor suppports AVIF.

/var/www/tests/phpunit/tests/rest-api/rest-attachments-controller.php:2579
/var/www/vendor/bin/phpunit:122

15) WP_Test_REST_Attachments_Controller::test_upload_unsupported_image_type_with_filter
The image editor suppports AVIF.

These two will be handled by #63967.

5) Test_Image_Resize_GD::test_resize_avif
No AVIF support in the editor engine WP_Image_Editor_GD on this system.

/var/www/tests/phpunit/tests/image/resize.php:104
/var/www/vendor/bin/phpunit:122

This last one should be resolved by the attached pull request, which tests an upstream pull request that adds AVIF support to GD. The attached pull request is testing an update to the Docker images maintained on GitHub.

#4 @wildworks
7 weeks ago

  • Milestone changed from 6.9 to 7.0

GD does not yet have support for the HEIC format, so this one can't be fixed at this time. Support for reading the Exif data from an HEIF file seems to be slated for PHP 8.5, but the pull request that adds support for manipulating these files is still in draft.