π₯ HOT: ClassicPress/ClassicPress/pull/ - High Quality
{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent updates to the SASS dependency (see #1597 and #1594) have started to display deprecation notices durung the
grunt sass:colorsbuild step.This PR aims to address these notices by modernising and updating the scss files, rather than simply silence the warnings.
Motivation and context
Cleaner build output.
How has this been tested?
Local testing and comparison of built files.
To compare before and after, on
developrungrunt sass:colorsand note the deprecation notices. Repeat that on this PR and see clean output.To compare the built CSS before and after, use the following series of commands to build the current CSS, rename the folder in
build/, build the CSS from the new file and then compare them. The final command should report nothing:Screenshots
Before
After
Types of changes