What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@noahtallen Saw you working on this in #49651. Was there a reason why start and/or end should be marked as undefined. I couldn't find anything.

I threw in another small JSDoc type error I had noticed while using this package as well.

I think I just copy/pasted the undefined portion from where it was originally added. So we should be ok, as long as no where in our code expects it to handle undefined.

Really appreciate the quick response @noahtallen 👍

I triggered the e2e tests again -- should be unrelated. Otherwise this is looking good! I'll merge once the checks pass.

I triggered the e2e tests again -- should be unrelated. Otherwise this is looking good! I'll merge once the checks pass.

Thanks!

Why has this been removed? These are optional.

Are they optional properties i.e. a typescript start?: number Or optionally set as undefined? Would you mind linking code where this would be set as undefined? My bad I must have totally missed it. Thanks.

Probably both. A rich text instance may not have selection

gutenberg/packages/block-editor/src/components/rich-text/index.js

Lines 149 to 150 in f706c86

	selectionStart: isSelected ? selectionStart.offset : undefined,
	selectionEnd: isSelected ? selectionEnd.offset : undefined,

gutenberg/packages/rich-text/src/component/use-input-and-selection.js

Line 269 in f706c86

const index = undefined;

O boy, looks like my eyes deceived me. Mind explaining to me the context for which you'd end up with an undefined value? In my usage I have never been able to get an undefined value appear when there is no selection or when there is. Attaching a short video:

Screen_Recording_2023-08-30_at_3.52.39_PM.mov

Would you like me to push another revert commit to put back the optional undefined? Are you good with the other change that was in this commit (the null value for className)?

While I have you attention, through for the wrong reason sadly, has there been any discussion about porting this package to typescript? If so, was there any blockers etc.

@ellatrix bumping this. Thanks.

All rich text instances have an undefined selection unless it is selected. So if you select one paragraph, all the other paragraph's rich text instances have an undefined selection except for the selected paragraph's.

@noahtallen I pulled in the updated types today. I believe name in settings should also be optional since it is overriding the value at the start of the function if it is defined via the first parameter.