💥 TRENDING: WordPress/gutenberg/pull/ - Collection
{{ message }}
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to better communicate the Hook intent.
Prior to making the asynchronous request to the host app across the bridge, it is a better UX to presume network connectivity is present rather than displaying network connectivity messages briefly.
Hoist the `OfflineStatus` indicator from the block list to the editor. The block list is leveraged for inner blocks, which means it rendered nested `OfflineStatus` indicators for blocks with inner blocks. Additionally, the `editor` package feels like an appropriate location for the offline detection component.
Improve the UX for screen reader users by announcing the state of network connectivity whenever it changes.
dcalhoun
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 683a122. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7262562263
|
Base automatically changed from
fix/prevent-offline-status-indicator-for-nested-block-lists
to
trunk
December 28, 2023 00:23
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Announce offline status when network connectivity is lost.
Why?
Fix wordpress-mobile/gutenberg-mobile#6475. Improve
the UX for users relying upon screen readers.
How?
Implement a React Hook for replicating "live regions" for both iOS and Android.
Announce a message whenever the network connection status changes.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
N/A, no visible changes proposed.