Summary

Fixes #399

Relevant technical choices

Checklist

• PR has either [Focus] or Infrastructure label.
• PR has a [Type] label.
• PR has a milestone or the no milestone label.

I thought I'd pick this one up, but a couple of SVG upload tests (test_get_dominant_color_none_images) are failing on various PHP versions 🤷

Thanks @swissspidy for picking. I also don't understood why it going fails 🤔

So the failures makes sense, because WP doesn't handle/support SVG uploads, so wp_check_filetype fails. And unfiltered uploads are not enabled either. The weird part is that the test is passing on PHP 7.4...

We don't really need to test SVG upload here anyway, so we can just remove it.

Tests on PHP < 7.3 are failing because the PHPUnit version (v9.6) is too new for those PHP versions, causing syntax errors.

We probably don't need something as complex as WordPress/plugin-check#321, but definitely something in that direction.

All the unit test pass ✅ now. Looking into integration tests setup.

There is no error output for failing runs, see e.g. https://github.com/WordPress/performance/actions/runs/7650368243/job/20846313421?pr=544

Do we need to log command.stderr?

@swissspidy Added log in script. In local i got below error for PHP 7.2.

ℹ Starting 'vendor/bin/phpunit -c phpunit.xml --verbose --testdox' on the tests-cli container. 
This version of PHPUnit requires PHP >= 7.3.
You are using PHP 7.2.34 (/usr/local/bin/php).

@swissspidy Added log in script. In local i got below error for PHP 7.2.

ℹ Starting 'vendor/bin/phpunit -c phpunit.xml --verbose --testdox' on the tests-cli container. 
This version of PHPUnit requires PHP >= 7.3.
You are using PHP 7.2.34 (/usr/local/bin/php).

Aah 💡

Now it makes sense. We need to downgrade PHPUnit in this case using composer update, just like we do for unit tests.

Maybe 7d560ae works 🤞

Or maybe not 🤷

Yay 🤩🥳

I found that calling composer update here causes problems: #961

Proposed fix: #962