💎 PREMIUM: WordPress/twentynineteen/pull/ - High Quality
{{ message }}
This repository was archived by the owner on Jan 15, 2019. It is now read-only.
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Downgrade event-stream dependency to 3.3.4 - Remove all references to flatmap-stream dependency - See github warning for more info: dominictarr/event-stream#116
…eam vulnerability
|
@allancole Pretty sure that the recommendation is version |
|
@TwoAbove I went ahead an just removed it entirely. This seemed to have no negative effects on the build script. Please test this and let me know if you discover any issues with it being removed completely :-) |
|
@allancole Let me clone and check |
|
@allancole |
There was a problem hiding this comment.
https://www.npmjs.com/package/npm-run-all is the culprit: updating to version 4.1.5 removed the malicious dependency
|
@allancole https://www.npmjs.com/package/npm-run-all pulls flatmap-stream. Updating to 4.1.5 fixes that (Sorry for the spam. Trying to help fix most of the stuff that we depend on even indirectly) |
|
Bumping Aside: To get a "safe" version of |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 30, 2018
This changes fixes a security issue found in a dependency script used in our build tool. - The malicious dependency is now removed and no longer called when running `npm install` or `npm run build`. - More info here: WordPress/twentynineteen#675 Props allancole, kjellr, netweb, twoabove. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@43956 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 30, 2018
This changes fixes a security issue found in a dependency script used in our build tool. - The malicious dependency is now removed and no longer called when running `npm install` or `npm run build`. - More info here: WordPress/twentynineteen#675 Props allancole, kjellr, netweb, twoabove. Built from https://develop.svn.wordpress.org/branches/5.0@43956 git-svn-id: http://core.svn.wordpress.org/branches/5.0@43788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Nov 30, 2018
This changes fixes a security issue found in a dependency script used in our build tool. - The malicious dependency is now removed and no longer called when running `npm install` or `npm run build`. - More info here: WordPress/twentynineteen#675 Props allancole, kjellr, netweb, twoabove. Built from https://develop.svn.wordpress.org/branches/5.0@43956 git-svn-id: https://core.svn.wordpress.org/branches/5.0@43788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
miya0001
pushed a commit
to cjk4wp/wordpress
that referenced
this pull request
Dec 4, 2018
This changes fixes a security issue found in a dependency script used in our build tool. - The malicious dependency is now removed and no longer called when running `npm install` or `npm run build`. - More info here: WordPress/twentynineteen#675 Props allancole, kjellr, netweb, twoabove. git-svn-id: http://develop.svn.wordpress.org/branches/5.0@43956 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical security issue found in a dependency related to our build script.