πŸ’₯ TRENDING: WordPress/wp feature notifications/pull/ - High Quality

Skip to content

Conversation

@johnhooks

What?

Create a minimum viable product of the notification plugin.

Why?

There is still a lot to learn, but we need a minimally functional system to explore the possiblities.

How?

Combines PRs:

Necessary functionality for MVP*

  • Activate
  • Uninstall
  • Classes
    • Channel
    • Channel_Registry
    • Message
    • Message_Factory
    • Notice
    • Notice_Factory
    • Subscription
    • Subscription_Factory
  • Database
    • Messages table
    • Queue table
    • Subscriptions table
    • Message_Repository
    • Notice_Repository (the queue table)
    • Subscription_Repository
  • REST API
    • Notification_Controller wp-notifications/v1/notifications
      • GET /notifications/
      • GET /notifications/{id}
      • POST /notifications/{id}
      • PUT /notifications /{id}
      • DELETE /notifications /{id}
    • Subscription_Controller wp-notifications/v1/subscriptions
      • GET /subscriptions/
      • GET /subscriptions/{id}
      • POST /subscriptions/{id}
      • PUT /subscriptions /{id}
      • DELETE /subscriptions /{id}
  • CLI Command
    • Seed users
    • Seed subscriptions
    • Seed notification messages
    • List registered channels
    • List user's notifications
    • List user's subscriptions
  • Only a rough outline right now, and heavily concentrated on the backend.

@johnhooks johnhooks force-pushed the feature/mvp branch 6 times, most recently from 745860b to cbe0996 Compare April 18, 2023 13:59
@Sephsekla

This is looking phenomenal already, thanks for the hard work here!

@johnhooks

@Sephsekla thanks, it feels like its coming a long well. Right now I'm going for simple, a lot will need adjusting to make the rest api function the way I would expect. Right now I don't have the right features in the models/factories/repositories for supporting _embed or _fields parameters in the rest api. But I am saving optimization and streamlining for later. For right now, we really just need to basic CRUD actions to get off the ground.

This was referenced Apr 19, 2023
@johnhooks johnhooks mentioned this pull request Apr 20, 2023
@Sephsekla Sephsekla linked an issue Apr 26, 2023 that may be closed by this pull request
8 tasks
@Sephsekla

@johnhooks when you have a sec, do you mind having a look at these merge conflicts? I'd like to try and get this rolling again by splitting out some of the remaining work (and possibly merging this one to development as is), but I'm not sure how to reslve things.

@johnhooks

@Sephsekla this branch should actually be closed, all of the features of this branch have already been merged in. I brought all of this into develop through smaller PRs.

@johnhooks johnhooks closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimum Viable Product - v0.3.0

4 participants