Opened 3 weeks ago
Closed 3 weeks ago
#8142 closed defect (bug) (fixed)
Release confirmations: Both buttons are styles as primary buttons.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Component: | Plugin Directory | Keywords: | has-patch |
| Cc: |
Description
On the release confirmation page, pending releases show two buttons. One to proceed with the release and one to discard the release.
Both of these buttons are styled as nice big blue primary buttons. Which can be confusing when confirming a release, it would be good if the destructive button could be styled as a secondary button.
Reading the code, I can see that the decline can be undone but it's not clear in the UI so can lead to undue angst if you don't realise this an almost click the wrong button.
Attachments (1)
Change History (6)
#2
@
3 weeks ago
IIRC this might've happened during the Block themeification, I believe prior to that they were primary/secondary, but I think the block theme didn't have the non-primary button style.
This ticket was mentioned in ​PR #532 on ​WordPress/wordpress.org by ​@manhphucofficial.
3 weeks ago
#3
- Keywords has-patch added
This change styles the destructive “Discard” release button as a secondary button, so it no longer appears the same as the primary “Confirm” action.
It keeps the existing behaviour intact and only adjusts the visual hierarchy of the actions.
​@manhphucofficial commented on ​PR #532:
3 weeks ago
#4
Thanks for the feedback!
You were absolutely right — my initial change only updated the class and didn't adjust the visual styling.
I've updated the PR to:
- Add a dedicated
.discard-releasestyle to thewporg-plugins-2024theme so the “Discard” button correctly appears as a secondary/outline action. - Keep the “Confirm” button as the primary action.
The “Discard” button now reflects the intended secondary hierarchy in the release confirmation dialog.
Happy to refine the styling or selectors further if needed!
Yeah, those release buttons can be scary. :)